Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #9151 - Drilldown event issue #10555

Merged
merged 1 commit into from
Aug 21, 2017
Merged

Fixes #9151 - Drilldown event issue #10555

merged 1 commit into from
Aug 21, 2017

Conversation

IamManchanda
Copy link
Contributor

@IamManchanda IamManchanda commented Aug 18, 2017

Updated by mistake ... Correcting now!
Closes #9151

Updated by mistake ... Correcting now!
@rafibomb
Copy link
Member

Not sure why we should remove the word menu, can you explain?

@IamManchanda
Copy link
Contributor Author

See #9151

The event name is still open.zf.drilldownMenu in docs, and needs to be open.zf.drilldown

Looks like it was fixed in f7e63fd by changing the docs title, but then the title was changed back 72844c8 for consistency. That probably reintroduced the issue.

@rafibomb
Copy link
Member

Oh wow, the event is tied to the name in the docs? We will likely want to decouple that in the future.

Sounds good for now - thanks @IamManchanda !!

@rafibomb rafibomb merged commit 373344e into develop Aug 21, 2017
@IamManchanda
Copy link
Contributor Author

Then again... this shows why good commit messages are very important!

Your welcome @rafibomb ... please request you to deploy it soon also... thank you

Thanks @shready for helping us figure it out... thumbs up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants