Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Drilldown Menu] Wrong JS events listed in Documentation #9151

Closed
callumisitt opened this issue Sep 1, 2016 · 4 comments
Closed

[Drilldown Menu] Wrong JS events listed in Documentation #9151

callumisitt opened this issue Sep 1, 2016 · 4 comments
Assignees
@IamManchanda

Comments

@callumisitt
Copy link

The Javascript events in the documentation for the Drilldown Menu appear to be wrong. I tried the open event, which is listed in the docs as 'open.zf.drilldownMenu', but nothing was happening when I set up a listener for it. Using 'open.zf.drilldown' however, worked as intended. This was with version 6.2.3.
@callumisitt callumisitt changed the title [Drilldown Menu] Incorrect JS events listed in Documentation [Drilldown Menu] Wrong JS events listed in Documentation Sep 1, 2016
@kball kball mentioned this issue Sep 30, 2016
Merged
@ahdigital
Copy link

This is still an issue in version 6.4.

@ozeone
Copy link

ozeone commented Jul 14, 2017

How come this has not been fixed in a release?
Googled for 1h before finding this, and solving my problems.

The event name is still open.zf.drilldownMenu in docs, and needs to be open.zf.drilldown

@shready
Copy link

shready commented Aug 18, 2017

Looks like it was fixed in f7e63fd by changing the docs title, but then the title was changed back 72844c8 for consistency. That probably reintroduced the issue.

@IamManchanda IamManchanda self-assigned this Aug 18, 2017
IamManchanda added a commit that referenced this issue Aug 18, 2017
@IamManchanda
Fixes #9151 - Drilldown event issue
28389c3 
Updated by mistake ... Correcting now!
@IamManchanda IamManchanda mentioned this issue Aug 18, 2017
Merged
@IamManchanda
Copy link
Contributor

Appologies folks... Have to accept my mistake... I just updated it for the sake of docs search but that was a mistake...

Fixed it now ... Added a PR!

rafibomb added a commit that referenced this issue Aug 21, 2017
@rafibomb
Merge pull request #10555 from zurb/drilldown-event-issue

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
373344e 
Fixes #9151 - Drilldown event issue
@DanielRuf DanielRuf mentioned this issue Feb 12, 2018
Closed
ncoden added a commit to ncoden/foundation-docs that referenced this issue Feb 12, 2018
@ncoden
fix: generate event names from the event scope
768c17c 
... instead of the page title

See:
- foundation/foundation-sites#9151
- foundation/foundation-sites#10932
- foundation/foundation-sites#10555
@ncoden ncoden mentioned this issue Feb 12, 2018
Merged
ncoden added a commit to ncoden/foundation-sites that referenced this issue Feb 12, 2018
@ncoden
Revert "Fixes foundation#9151 - Drilldown event issue"

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
fbe133e 
This reverts commit 28389c3.
See: foundation/foundation-docs#24
ncoden added a commit that referenced this issue Feb 18, 2018
@ncoden
Merge pull request #10933 from ncoden/clean/revert-10555
0f6cfd2 
clear: revert #10555 "Fixes #9151 - Drilldown event issue"
ncoden added a commit to ncoden/foundation-sites that referenced this issue Jun 16, 2018
@ncoden
Use pull request foundation#10933 from ncoden/clean/revert-10555 for …
d1bdf83 
…v6.5.0

fbe133e Revert "Fixes foundation#9151 - Drilldown event issue"

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Jun 16, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IamManchanda IamManchanda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ahdigital @ozeone @IamManchanda @callumisitt @shready