Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix example for custom validator #11035

Merged
merged 2 commits into from
Mar 13, 2018
Merged

docs: fix example for custom validator #11035

merged 2 commits into from
Mar 13, 2018

Conversation

lirael
Copy link
Contributor

@lirael lirael commented Mar 10, 2018

Foundation initialization was misplaced in the example, hence it was confusing. Discussed in #9773 . Fixes #11033 .

@lirael
docs: fix example for custom validator
dded67f 
Foundation initialization was misplaced in the example, hence it was confusing. Discussed in foundation#9773.
@lirael lirael mentioned this pull request Mar 10, 2018
Closed
ncoden
ncoden approved these changes Mar 10, 2018
View reviewed changes
Copy link
Contributor

@ncoden ncoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lirael, thank you for your first contributions !

I added some documentation about the parameters of the validator, I think it was missing.

LGTM for merging. 👍

@ncoden ncoden merged commit d956136 into foundation:master Mar 13, 2018
ncoden added a commit to ncoden/foundation-sites that referenced this pull request Jun 16, 2018
@lirael @ncoden
Use pull request foundation#11035 from lirael/docs/abide-fix-custom-v…
c34584d 
…alidator-foundation-initialization for v6.5.0

dded67f docs: fix example for custom validator
3bfb07b docs: add infos in the Abide custom validator example

Co-Authored-By: Nicolas Coden <nicolas@ncoden.fr>
Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Jun 16, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncoden ncoden ncoden approved these changes

Assignees
No one assigned
Labels
Abide 📖 documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lirael @ncoden @DanielRuf