docs: fix example for custom validator #11033
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fying Fixed flex horizontal alignment. Issue foundation#10125
…-height Add height pinning to cell-block-y
…b.com/DaSchTour/foundation-sites into DaSchTour-andycochran-responsive-expanded-buttons
Added the ability to use the xy-cell-base mixin to grow the flex item to take up all available space. This is effectively the same as: `.flex-child-grow`, found @ https://foundation.zurb.com/sites/docs/flexbox-utilities.html#vanilla-flexbox-helper-classes - But there isn't a way to do this through the SASS mixins.
Updated the comment, and by extension, the docs to include the extra parameter.
Resolves issue#10657 (When closeOnClick option is true, clicking on t…
Fix reset for y-grid to clear max-width as well
Add grow to xy-cell-base
Set aria-invalid attribute when something is not valid, see [here (Mailinglist)](http://lists.w3.org/Archives/Public/public-pfwg/2015Jul/0031.html) and [here (Spec)](https://www.w3.org/TR/wai-aria-1.1/#aria-invalid).
Added aria-onerrormessage attributes where needed. See [here (Spec)](https://www.w3.org/TR/wai-aria-1.1/#aria-errormessage). Fixed multiple elements having the same ID.
Edits to make push, pull, and offset optional to foundation-grid
Fixing optional for push and pull for Gutter adjustment
Allowing center and uncenter to be optional
…it-test fix: do not test for inferred names in getFnName unit test
…e-modifiers-reset-10891 fix: fix XY Grid responsive widths with shrink/auto foundation#10891
…bility See: foundation#11006 (comment) Previous PR: foundation#11006 (@DanielRuf) Closes foundation#10771 (@hubert-ried)
Partially revert e89d85c Test Magellan.scrollToLoc systematically as it should _never_ throw an error when target does not exists.
…l-node-versions tests: run tests on latest stable and LTS releases of Node.js
…used-variable-expand-max-8484 fix: remove the unused tab-expand-max variable
…wn-eventnames fix: camelCase all events
…used-hover-variable-10758 fix: remove the unused menu-item-background-hover variable
…compatibility-10771 fix: use `hashchange` event instead of `popstate` for IE/Edge compatibility
…e-active fix: fire updateActive after calcPoints
Foundation initialization was misplaced in the example, hence it was confusing. Discussed in foundation#9773.
|
I guess you have to rebase, and create the branch from master. |
|
Thanks for your contribution. But I'll close this one. Let me know if you need help and I'll give you the needed steps to create a new, clean branch. |
|
You have to use the master branch for the docs. Try the following: git checkout master
git checkout -b docs/abide-fix-custom-validator-foundation-initialization
git cherry-pick 10eeb3555ef087749bec7534adc642ced2bc4e51
git push -u origin docs/abide-fix-custom-validator-foundation-initializationThen select the foundation-sites/master branch as target when creating the PR. |
|
@DanielRuf thanks for all your explanations and help! New PR #11035 |
This was referenced Jun 16, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Foundation initialization was misplaced in the example, hence it was confusing. Discussed in #9773.