Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove obsolete sasslint comments #11231

Merged
merged 1 commit into from May 3, 2018
Merged

chore: remove obsolete sasslint comments #11231

merged 1 commit into from May 3, 2018

Conversation

DanielRuf
Copy link
Contributor

Description

This PR removes the now obsolete sasslint comments as the other PR was closed too early ;-)

Motivation and Context

Remove obsolete sasslint comments.

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to change)

Checklist (all required):

  • I have read and follow the CONTRIBUTING document.
  • There are no other pull request similar to this one.
  • The pull request title is descriptive.
  • The template is fully and correctly filled.
  • The pull request targets the right branch (develop or support/*).
  • My commits are correctly titled and contain all relevant information.
  • My code follows the code style of this project.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).
  • All new and existing tests passed.

@DanielRuf DanielRuf added the scss label May 2, 2018
ncoden
ncoden approved these changes May 3, 2018
View reviewed changes
Copy link
Contributor

@ncoden ncoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍. Next time could you put a [WIP] flag when the PR is not ready to merge ?

@DanielRuf
Copy link
Contributor Author

Understood.

@ncoden ncoden merged commit 3c03ba5 into foundation:develop May 3, 2018
@DanielRuf DanielRuf deleted the chore/remove-obsolete-sasslint-comments branch May 3, 2018 19:52
ncoden pushed a commit to ncoden/foundation-sites that referenced this pull request Jun 16, 2018
@DanielRuf @ncoden
Use pull request foundation#11231 from DanielRuf/chore/remove-obsolet…
49dcd48 
…e-sasslint-comments for v6.5.0

59e2d9e chore: remove obsolete sasslint comments

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Jun 16, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncoden ncoden ncoden approved these changes

Assignees
No one assigned
Labels
scss
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielRuf @ncoden