Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove obsolete sasslint comments #11231

Merged
merged 1 commit into from May 3, 2018
Merged

chore: remove obsolete sasslint comments #11231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions scss/components/_accordion-menu.scss
View file
Original file line number Diff line number Diff line change
@@ -51,7 +51,7 @@ $accordionmenu-submenu-toggle-height: $accordionmenu-submenu-toggle-width !defau
$accordionmenu-arrow-size: 6px !default;

@mixin zf-accordion-menu-left-right-arrows {
.is-accordion-submenu-parent:not(.has-submenu-toggle) > a { // sass-lint:disable-line force-element-nesting force-pseudo-nesting
.is-accordion-submenu-parent:not(.has-submenu-toggle) > a {
position: relative;

&::after {
@@ -63,12 +63,12 @@ $accordionmenu-arrow-size: 6px !default;
}
}

&.align-left .is-accordion-submenu-parent > a::after { // sass-lint:disable-line force-element-nesting force-pseudo-nesting
&.align-left .is-accordion-submenu-parent > a::after {
right: 1rem;
left: auto;
}

&.align-right .is-accordion-submenu-parent > a::after { // sass-lint:disable-line force-element-nesting force-pseudo-nesting
&.align-right .is-accordion-submenu-parent > a::after {
right: auto;
left: 1rem;
}
@@ -96,31 +96,31 @@ $accordionmenu-arrow-size: 6px !default;
padding: $accordionmenu-padding;
}

.is-accordion-submenu a { // sass-lint:disable-line force-element-nesting
.is-accordion-submenu a {
padding: $accordionmenu-submenu-padding;
}

.nested.is-accordion-submenu { // sass-lint:disable-line force-element-nesting
.nested.is-accordion-submenu {
@include menu-nested($accordionmenu-nested-margin);
}

&.align-#{$global-right} {
.nested.is-accordion-submenu { // sass-lint:disable-line force-element-nesting
.nested.is-accordion-submenu {
@include menu-nested($accordionmenu-nested-margin, right);
}
}

@if $accordionmenu-arrows {
@include zf-accordion-menu-left-right-arrows;

.is-accordion-submenu-parent[aria-expanded='true'] > a::after { // sass-lint:disable-line force-element-nesting force-pseudo-nesting force-attribute-nesting
.is-accordion-submenu-parent[aria-expanded='true'] > a::after {
transform: rotate(180deg);
transform-origin: 50% 50%;
}
}
}

.is-accordion-submenu li { // sass-lint:disable-line force-element-nesting force-attribute-nesting
.is-accordion-submenu li {
@if $accordionmenu-border {
border-right: 0;
border-left: 0;
@@ -163,7 +163,7 @@ $accordionmenu-arrow-size: 6px !default;
}

// Rotate the arrow when menu is open
.submenu-toggle[aria-expanded='true']::after { // sass-lint:disable-line force-element-nesting force-pseudo-nesting force-attribute-nesting
.submenu-toggle[aria-expanded='true']::after {
transform: scaleY(-1);
transform-origin: 50% 50%;
}
8 changes: 4 additions & 4 deletions scss/components/_button-group.scss
View file
Original file line number Diff line number Diff line change
@@ -121,8 +121,8 @@ $buttongroup-radius-on-each: true !default;

// Two or more childreen
@for $i from 2 through $buttongroup-expand-max {
&:first-child:nth-last-child(#{$i}) { // sass-lint:disable-line force-pseudo-nesting
&, &:first-child:nth-last-child(#{$i}) ~ #{$selector} { // sass-lint:disable-line force-pseudo-nesting
&:first-child:nth-last-child(#{$i}) {
&, &:first-child:nth-last-child(#{$i}) ~ #{$selector} {
display: inline-block;
width: calc(#{percentage(1 / $i)} - #{$spacing});
margin-#{$global-right}: $spacing;
@@ -214,7 +214,7 @@ $buttongroup-radius-on-each: true !default;

// Sizes
@each $size, $value in map-remove($button-sizes, default) {
&.#{$size} #{$buttongroup-child-selector} { // sass-lint:disable-line force-element-nesting
&.#{$size} #{$buttongroup-child-selector} {
font-size: $value;
}
}
@@ -240,7 +240,7 @@ $buttongroup-radius-on-each: true !default;
@each $name, $color in $button-palette {
$individual-selector: if($button-fill == $filling, null, ' #{$buttongroup-child-selector}.#{$name}');

&.#{$name} #{$buttongroup-child-selector}, #{$individual-selector} { // sass-lint:disable-line force-element-nesting
&.#{$name} #{$buttongroup-child-selector}, #{$individual-selector} {
@include button-fill-style($filling, $color, auto, auto);
}
}
2 changes: 1 addition & 1 deletion scss/forms/_range.scss
View file
Original file line number Diff line number Diff line change
@@ -39,7 +39,7 @@ $slider-opacity-disabled: 0.25 !default;
$slider-radius: $global-radius !default;

@mixin foundation-range-input {
input[type='range'] { // sass-lint:disable-line no-qualifying-elements force-attribute-nesting
input[type='range'] { // sass-lint:disable-line no-qualifying-elements
$margin: ($slider-handle-height - $slider-height) / 2;

display: block;
2 changes: 1 addition & 1 deletion scss/forms/_text.scss
View file
Original file line number Diff line number Diff line change
@@ -155,7 +155,7 @@ $form-button-radius: $global-radius !default;
}

// Reset Normalize setting content-box to search elements
input[type='search'] { // sass-lint:disable-line no-qualifying-elements force-attribute-nesting
input[type='search'] { // sass-lint:disable-line no-qualifying-elements
box-sizing: border-box;
}