Bump golangci-ling to 1.51.2 #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm helping with LmP upgrade of Golang to 1.20 for fioconfig. So, my system-wide Golang version was upgraded to version 1.20. But, for some weird reason, older golangci-lint stopped working after that regardless of the go1.19 flag in go.mod. It looks like it uses some of the Golang internals. The easiest solution is to upgrade golangci-lint to a newer version, which support Golang 1.17+. Looking ahead, this is a good addition anyway to stay tuned. Signed-off-by: Volodymyr Khoroz <volodymyr.khoroz@foundries.io>
|
Maybe, these tickets help:
In short: we need to upgrade golint every time Golang releases a new version and we plan to support it. |
doanac
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm helping with LmP upgrade of Golang to 1.20 for fioconfig. So, my system-wide Golang version was upgraded to version 1.20. But, for some weird reason, older golangci-lint stopped working after that regardless of the go1.19 flag in go.mod.
It looks like it uses some of the Golang internals. The easiest solution is to upgrade golangci-lint to a newer version, which support Golang 1.17+.
Looking ahead, this is a good addition anyway to stay tuned.
Signed-off-by: Volodymyr Khoroz volodymyr.khoroz@foundries.io