-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish cleanup of text #436
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doanac
reviewed
Oct 10, 2024
kprosise
commented
Oct 15, 2024
kprosise
force-pushed
the
cleanup-help-part2
branch
from
October 18, 2024 14:30
58db58f
to
1e6371a
Compare
vkhoroz
reviewed
Oct 22, 2024
kprosise
commented
Oct 23, 2024
kprosise
commented
Oct 23, 2024
kprosise
commented
Oct 23, 2024
kprosise
commented
Oct 23, 2024
kprosise
commented
Oct 23, 2024
This is part 2 of 2 of the effort to cleanup the text for help commands and logging. Mostly minor changes made so as to align with style-guide, or in a effort to increase readability. This commit addresses FFTK-2391, "Fix Fioctl style and typos" Signed-off-by: Katrina Prosise <katrina.prosise@foundries.io>
kprosise
force-pushed
the
cleanup-help-part2
branch
from
October 23, 2024 12:05
cf83199
to
cd54ad2
Compare
vkhoroz
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@doanac Okay, I believe all feedback has been addressed! |
Is this okay to merge soon? Just want to mark it off my list :) |
doanac
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 2 of 2 of the effort to cleanup the text for help commands and logging. Mostly minor changes made so as to align with style-guide, or in a effort to increase readability.
This commit addresses FFTK-2391, "Fix Fioctl style and typos"