Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish cleanup of text #436

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

kprosise
Copy link
Contributor

This is part 2 of 2 of the effort to cleanup the text for help commands and logging. Mostly minor changes made so as to align with style-guide, or in a effort to increase readability.

This commit addresses FFTK-2391, "Fix Fioctl style and typos"

subcommands/targets/add.go Outdated Show resolved Hide resolved
subcommands/targets/deltas.go Show resolved Hide resolved
subcommands/targets/add.go Outdated Show resolved Hide resolved
subcommands/targets/tag.go Outdated Show resolved Hide resolved
subcommands/version/cmd.go Outdated Show resolved Hide resolved
subcommands/version/update_self_windows.go Outdated Show resolved Hide resolved
subcommands/waves/cmd.go Outdated Show resolved Hide resolved
subcommands/waves/status.go Outdated Show resolved Hide resolved
subcommands/targets/tag.go Outdated Show resolved Hide resolved
subcommands/version/cmd.go Outdated Show resolved Hide resolved
subcommands/waves/cmd.go Outdated Show resolved Hide resolved
subcommands/waves/status.go Outdated Show resolved Hide resolved
This is part 2 of 2 of the effort to cleanup the text for help commands
and logging. Mostly minor changes made so as to align with style-guide,
or in a effort to increase readability.

This commit addresses FFTK-2391, "Fix Fioctl style and typos"

Signed-off-by: Katrina Prosise <katrina.prosise@foundries.io>
Copy link
Member

@vkhoroz vkhoroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kprosise
Copy link
Contributor Author

@doanac Okay, I believe all feedback has been addressed!

@kprosise
Copy link
Contributor Author

kprosise commented Nov 6, 2024

Is this okay to merge soon? Just want to mark it off my list :)

@doanac doanac merged commit b1422ab into foundriesio:main Nov 6, 2024
8 checks passed
@kprosise kprosise deleted the cleanup-help-part2 branch November 6, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants