Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the test functions to adhere to the Foundry best practices #273

Closed
PaulRBerg opened this issue Jan 10, 2023 · 0 comments · Fixed by #433 or #600
Closed

Rename the test functions to adhere to the Foundry best practices #273

PaulRBerg opened this issue Jan 10, 2023 · 0 comments · Fixed by #433 or #600

Comments

@PaulRBerg
Copy link
Contributor

PaulRBerg commented Jan 10, 2023

As suggested in the Best Practices section of the Foundry Book, and as discussed in more detail here, it is recommended to name the test functions like this:

  • test_Description
  • testFuzz_Description
  • test_Revert[If|When]_Description
  • testFork_Description
  • testForkFuzz_Revert[If|When]_Description

Doing this would also make the test lintable by scopelint when the tool is production-ready.

The tests in this repo do not, however, conform to this best practice yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant