chore: conform test naming to style guide

[Sabnock01]

This PR puts the forge-std test naming conventions in line with the style guide

Some liberties have been taken with respect to the names in StdAssertions.t.sol but open to any feedback.

I did not add any test names with the Revert[If|When] modifier since none of the tests appear to pass or fail conditionally. Correct me if this is erroneous.

Closes #273

[mds1]

I did not add any test names with the Revert[If|When] modifier since none of the tests appear to pass or fail conditionally.

Sorry what do you mean by this bolded part? Also just to clarify, the Revert[If|When] convention doesn't affect execution, it just signals you're testing that something should revert. This is useful because for any time you want to filter happy path vs. failure cases, such as excluding reverting tests when generating gas reports

[mds1]

This is great, thanks @Sabnock01! Just about ready to merge, but want to bump the question in #433 (comment) first

[Sabnock01]

This is great, thanks @Sabnock01! Just about ready to merge, but want to bump the question in #433 (comment) first

Ah, no problem. I was trying to say that specific syntax didn't appear necessary for any of the current tests but I don't recall specifically why I worded it the way I did.

[mds1]

Ah got it. Yea of course it’s not strictly necessary, but since we’re updating to follow the best practices doc conventions we may as well use that one too, for tests that are focused on checking revert conditions. Would you mind using that where applicable?

[Sabnock01]

Ah got it. Yea of course it’s not strictly necessary, but since we’re updating to follow the best practices doc conventions we may as well use that one too, for tests that are focused on checking revert conditions. Would you mind using that where applicable?

Sure, can do that.

[mds1]

Thanks so much!