-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming tests to follow best practices from Foundry Book #600
Conversation
As I mentioned earlier, I have suggested small changes to best practices.Here is a table overview of methods from this file.
I feel that the third approach is most clear and also makes it very easy to search for specific tests, e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Per foundry-rs/book#1279 (comment) let's keep the current convention that you have now, this looks great
This PR puts the
forge-std
test naming conventions in line with the Best Practices from Foundry Book.I am looking for a response if I should additionally rename tests as stated here in #599 . After I get the feedback, I will make changes to other test files too.
This PR closes #273 and #599 . Additionally, I could adapt it to fit suggestion on the book best practice test naming changes if this suggestion gets accepted.