Invalid validation of pending transactions

[ngotchac]

Component

Anvil

Have you ensured that all of these are up to date?

• Foundry
• Foundryup

What version of Foundry are you on?

No response

What version of Foundryup are you on?

No response

What command(s) is the bug in?

No response

Operating System

None

Describe the bug

It seems that the validation of pending transactions, when anvil is started w/o automine, is sometimes rejecting valid transactions.

That's the case when:

• (1) A transaction is funding an account
• (2) Another transaction from the funded account in (1) is sending more value than its balance before (1)

For example:

anvil --fork-block-number 49683935 --fork-url http://archive.bsc

$ cast publish "$(cast-bsc tx 0x8509e4a7ee4830e5435a0253144511c1183f88e6fd521eb8805ad21d875736bd --raw)" --async
OK

$ cast publish "$(cast-bsc tx 0xecf4eac0d9ae901037fd2b527170f45e11750e67f317a635050b44ec39abe2bc --raw)" --async
Error: server returned an error response: error code -32003: Insufficient funds for gas * price + value

The second tx would be valid if mined/validated of the first one.

---

I'm not sure what the best option is. Maybe a way to force a tx/bypass those checks?

[mattsse]

this validation makes sense because the second tx would only be valid on top of tx2 but the first tx1 is validated against the state of the latest block.

best workaround for this would be a validation setting, maybe --disbale-pool-balance-checks or similar?

[ngotchac]

Exactly, this makes sense, but it's blocking for some use cases. Your suggestion makes sense and I think should work :) Or be able to push a batch of txs, validated on top of each other?

[mablr]

@ngotchac Please, let me know if you think if the test of the PR I submitted reflects well you use case.

https://github.com/foundry-rs/foundry/pull/11242/files#diff-fd8658513db931996423d1470af7a57d994d407aa87c1f8d23a062f0698ed655R59-R116

[ngotchac]

Please, let me know if you think if the test of the PR I submitted reflects well you use case.

The test looks good! I'll try to run our usecase on your branch and report back :)

[ngotchac]

@mablr It works wunderfully! For full reproduction:

anvil --fork-block-number 49683935 --fork-url http://<archive.bsc> --disable-pool-balance-checks --no-mining --order fifo

and

cast publish "$(cast-bsc tx 0x979ec3672b640084754eb7d43f9250aeb531e668dbbfe6c0b5c14813bae4b1ca --raw)" --async
cast publish "$(cast-bsc tx 0xe36dffb266b2c5cc8bd2011d738fd12669a3bde44ef8c7b7a5a6ff1a7c2fcf66 --raw)" --async
cast publish "$(cast-bsc tx 0x8509e4a7ee4830e5435a0253144511c1183f88e6fd521eb8805ad21d875736bd --raw)" --async
cast publish "$(cast-bsc tx 0xecf4eac0d9ae901037fd2b527170f45e11750e67f317a635050b44ec39abe2bc --raw)" --async

cast rpc evm_mine

Thanks, that was fast 🎉