Fix integration tests and cross-platform test

[onbjerg]

• Cross-platform tests are failing because of directory separators and line endings on Windows
• Integration tests are now passing

[gakonst]

For geb, the stop gap would be to use solc 0.6.7 and run it with --no-auto-detect, vs allowing it to fail the compilation step (might as well remove it in that case)

[onbjerg]

I think we should pursue figuring out why the version detecting fails instead then. I think it might be a bug in solang-parser. When I tried running the integration test for geb locally with RUST_LOG=trace there were a lot of test files we couldn't parse because they use decimal numbers with exponents. Has been fixed in hyperledger-solang/solang#646

[gakonst]

Specifically for Geb this is what I had seen

there’s actually 2 bugs

1. the contracts compiled with 0.8.11 outside of delegate.sol are actually all contracts with empty code in them so we should not be creating jobs where source has no code for compilation, wonder if we can check that somehow, they are full of comments
2. delegate.sol gets used in both jobs

[brockelmore]

we should likely add a hardhat repo as an integration test if at all possible. I know we dont expect 0 overhead for most cases but we should try to find one that "it just works" for and add it

[onbjerg]

Updated OP to reflect the latest state of integration tests

[onbjerg]

Update, we fixed what we could here and then I fixed geb tests upstream. Our integration tests are now passing!

[gakonst]

@onbjerg can we re-enable Geb but only have it run with solc 0.7.6?

Maybe we should add a flag called "--solc-version" which loads solc from PATH or SOLC_PATH (if it matches the requested version) or from ~/.svm/ or tries to install it via svm?

That way anyone could do "forge test --solc-version x.y.z" and it'd auto select that / download it if not present

[onbjerg]

Yes, let's do that

[onbjerg]

Going to keep this open until we re-enable geb