-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aarch64 Linux to the nightly build #684
Comments
The Solidity compiler does not have ARM builds, so I'm not sure it would make much sense - can you elaborate a little? |
That's true, Solidity compiler doesn't provide pre-compiled ARM builds. However, (1) it's still possible to use |
@nikitastupin Do you think you could manually compile and create a repo with ARM builds for Solc versions, and host it on Github? Then we could use that as source of truth instead. Trail of Bits did something similar here https://github.com/crytic/solc/tree/master/linux/amd64 @onbjerg I think let's just add it to the releases, the argument made here makes sense, both for |
I think I could invest a couple of hours trying to automate ARM build 😃 It would help myself in the future and others. Also, the ethereum/solidity#11351 issue tracks Solidity's progress on the same issue. They consider it low-priority though. |
That's be awesome. Appreciate it. Let us know when you have it, so we integrate it in svm-rs. I think we cannot depend on it getting solved at core Solidity soon, we've asked them directly very recently and got the same answer |
It seems that it's not that hard to automate aarch64-linux builds. I started working on it at https://github.com/nikitastupin/solc. The core is GitHub Actions workflow that I manually trigger to run a build process for a specified version of Solidity compiler and then upload the binary back to the repo via Releases. |
A quick update on https://github.com/nikitastupin/solc. I decided to keep it simple and store binaries in the repo instead of Releases and uploaded Does the repo structure looks good for you? Any other comments? |
This looks great. Flagged it to @roynalnaruto, he'll incorporate this in svm-rs. Thank you @nikitastupin! |
@nikitastupin Hi, that's great work! I wish to make an addition to your I cannot see the I'll wrap up the rest of the changes required and file a PR to your repo by tmrw :) |
bumps svm-rs. fixes #525 fixes #684 driveby: re-enable geb integration test (fixed in gakonst/ethers-rs#866) fixes #561
bumps svm-rs. fixes #525 fixes #684 driveby: re-enable geb integration test (fixed in gakonst/ethers-rs#866) fixes #561
bumps svm-rs. fixes foundry-rs/foundry#525 fixes foundry-rs/foundry#684
bumps svm-rs. fixes foundry-rs/foundry#525 fixes foundry-rs/foundry#684
Component
Foundryup
Describe the feature you would like
Hey 👋
Can we add the aarch64 Linux target to the nightly build? It would be nice so that me and other aarch64 Linux users won't need to rebuild from sources each time.
It should be just adding a few lines to
release.yml
.Thanks!
Additional context
No response
The text was updated successfully, but these errors were encountered: