Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: build arm64 linux nightlies #694

Merged
merged 4 commits into from
Feb 8, 2022
Merged

ci: build arm64 linux nightlies #694

merged 4 commits into from
Feb 8, 2022

Conversation

onbjerg
Copy link
Member

@onbjerg onbjerg commented Feb 7, 2022 •
edited
Loading

If I read foundryup correctly this should already be supported, so this is the only change needed, given Cargo doesn't complain

Closes #684

@onbjerg
Copy link
Member Author

onbjerg commented Feb 7, 2022 •
edited
Loading

Should we add a warning to foundryup when installing on ARM platforms that Foundry only works with autodetection turned off, or should we just ship as-is given we're trying to land ARM support in svm-rs?

Edit: Converting this to a draft - I'll test that Cargo doesn't complain on my Linux machine when I get back home

@onbjerg onbjerg marked this pull request as draft February 7, 2022 17:46
@gakonst
Copy link
Member

gakonst commented Feb 7, 2022 •
edited
Loading

I'd do:

  1. Add a warning that "forge on arm has autodetection disabled. you can track progress in Add support for Apple Silicon #525". Arm support might take a while, depends on who will step up to build the ARM binaries and PR them
  2. I'd add a cfg target = arm here and always make it true, so that the user can't footgun

@onbjerg
fix: disable solc autodetection on arm
4314eac
@onbjerg
fix: add autodetect warning on arm devices
cc81ee1 
Forge will output a warning on ARM devices stating that
autodetection is disabled, unless autodetection is explicitly
disabled by the user to silence the warning.
@onbjerg
Copy link
Member Author

onbjerg commented Feb 8, 2022 •
edited
Loading

Wasn't entirely sure where to put the warning, so I ended up printing the warning on any build if --no-auto-detect is not passed. Thoughts? @gakonst

Also this fails due to openssl-sys looking for OpenSSL even though we build with the rustls feature... It even fails when using cross. Any ideas here?

@gakonst gakonst marked this pull request as ready for review February 8, 2022 08:05
@gakonst gakonst merged commit 2834702 into master Feb 8, 2022
@onbjerg
Copy link
Member Author

onbjerg commented Feb 8, 2022 •
edited
Loading

It wasn't supposed to be merged yet, it isn't working due to the above SSL error 😄

onbjerg added a commit that referenced this pull request Feb 8, 2022
@onbjerg
Revert "ci: build arm64 linux nightlies (#694)"
b93686a 
This reverts commit 2834702.
@onbjerg onbjerg mentioned this pull request Feb 8, 2022
Merged
onbjerg added a commit that referenced this pull request Feb 8, 2022
@onbjerg
revert: arm64 linux nightlies (#694) (#703)
28f6d91 
This reverts commit 2834702.
@onbjerg onbjerg added the L-ignore Log: ignore PR in changelog label Feb 8, 2022
@gakonst gakonst deleted the onbjerg/linux-arm-releases branch February 9, 2022 11:55
@gakonst gakonst mentioned this pull request Feb 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
L-ignore Log: ignore PR in changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add aarch64 Linux to the nightly build
2 participants
@onbjerg @gakonst