Revert "fix(remappings): check if remapping to add starts with existing remapping name (#9246)" #9274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng remapping name (foundry-rs#9246)" This reverts commit 455ba9b.
grandizzy
requested review from
DaniPopes,
klkvr,
mattsse,
yash-atreya and
zerosnacks
as code owners
zerosnacks
approved these changes
Nov 6, 2024
2 tasks
rplusq
pushed a commit
to rplusq/foundry
that referenced
this pull request
Nov 29, 2024
…ng remapping name (foundry-rs#9246)" (foundry-rs#9274) This reverts commit 455ba9b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 455ba9b.
Motivation
Fix added in #9246 affects existing projects compilation
The changed code (checking remappings to add against existing) doesn't account scenario where
@openzeppelin/contractsis already added and@openzeppelin/contracts-upgradeableremapping will be discarded (as remapping to add name starts with existing)Revert and investigate failures
Closes #9271
Closes #9272
Solution