fix(forge): consistent handling unresolved imports #11164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
previously approved these changes
Jul 31, 2025
grandizzy
requested review from
klkvr,
mattsse,
yash-atreya and
zerosnacks
as code owners
|
@DaniPopes pls recheck, your review was dismissed when pushing test |
grandizzy
force-pushed
the
bump-compilers-fix-11149
branch
from
ce62128 to
9271526
Compare
DaniPopes
approved these changes
Jul 31, 2025
grandizzy
added a commit
to grandizzy/foundry
that referenced
this pull request
Aug 5, 2025
* fix(forge): consistent handling unresolved imports * Add test
grandizzy
added a commit
that referenced
this pull request
Aug 5, 2025
* fix(cast): use all providers if local artifacts used (#11090) * fix(cast): use all providers if local artifacts used * Fix * fix(cast): improve handling of `mktx --raw-unsigned` with runtime validation (#11111) * fix(mktx): improve handling of `--raw-unsigned` with runtime validation - Updated the logic for handling the `--from` argument in the `run` function. - Added validation for required `nonce` parameter when `--from` is not provided, ensuring necessary transaction details are specified. - Used `Address::ZERO` as a placeholder when there is no need to query provider - unit tests * fix: fmt * fix(`anvil`): unwrap panic in `eth/backend/mem/mod.rs` (#11141) make typed request casting not panic and return useful error to user * fix(forge): consistent handling unresolved imports (#11164) * fix(forge): consistent handling unresolved imports * Add test * fix(lint): exclude disabled ids in multi-lint passes (#11122) * fix: use empty 7702 auths (#11182) * fix(forge): bump compilers to fix remapping sol file (#11184) * Bump compilers 0.18.2 * Add test * fix(coverage): disambiguate duplicate function names (#11188) * fix(forge): set state changes journal in active fork (#11196) * chore(ci): fix `typos` CI job failing (#11198) fix typos * Bump version 1.3.1 (#11199) * fix(forge): improve error messages for etherscan verification failures (#11194) * fix(forge): improve error messages for etherscan verification failures * fix: cargo clippy * tests(forge): add tests for unknown chain id * fix: err formating for EtherscanConfigError --------- Co-authored-by: zerosnacks <95942363+zerosnacks@users.noreply.github.com> * chore(tests): bump forge-std version (#11174) * chore: bump forge-std version used for tests * Fixes --------- Co-authored-by: DaniPopes <DaniPopes@users.noreply.github.com> Co-authored-by: grandizzy <grandizzy.the.egg@gmail.com> --------- Co-authored-by: Mablr <59505383+mablr@users.noreply.github.com> Co-authored-by: zerosnacks <95942363+zerosnacks@users.noreply.github.com> Co-authored-by: 0xrusowsky <90208954+0xrusowsky@users.noreply.github.com> Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Co-authored-by: Shiyas Mohammed <83513144+shiyasmohd@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DaniPopes <DaniPopes@users.noreply.github.com>
MerkleBoy
pushed a commit
to MerkleBoy/foundry
that referenced
this pull request
Sep 17, 2025
* fix(forge): consistent handling unresolved imports * Add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
forge compile --jsondoes not emit valid JSON on invalid absolute import paths #11149Solution
PR Checklist