Skip to content

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Aug 1, 2025

closes #11169

this should be okay, because this will get enforced by the evm and then bubbles up the appropriate error

Copy link
Collaborator

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, given that it will reject in REVM

@grandizzy grandizzy merged commit 40ac685 into master Aug 1, 2025
22 checks passed
@grandizzy grandizzy deleted the matt/use-empty-7702-auths branch August 1, 2025 15:25
@github-project-automation github-project-automation bot moved this to Done in Foundry Aug 1, 2025
grandizzy pushed a commit to grandizzy/foundry that referenced this pull request Aug 5, 2025
@grandizzy grandizzy mentioned this pull request Aug 5, 2025
3 tasks
grandizzy added a commit that referenced this pull request Aug 5, 2025
* fix(cast): use all providers if local artifacts used (#11090)

* fix(cast): use all providers if local artifacts used

* Fix

* fix(cast): improve handling of `mktx --raw-unsigned` with runtime validation (#11111)

* fix(mktx): improve handling of `--raw-unsigned` with runtime validation

- Updated the logic for handling the `--from` argument in the `run` function.
- Added validation for required `nonce` parameter when `--from` is not provided, ensuring necessary transaction details are specified.
- Used `Address::ZERO` as a placeholder when there is no need to query provider
- unit tests

* fix: fmt

* fix(`anvil`): unwrap panic in `eth/backend/mem/mod.rs` (#11141)

make typed request casting not panic and return useful error to user

* fix(forge): consistent handling unresolved imports (#11164)

* fix(forge): consistent handling unresolved imports

* Add test

* fix(lint): exclude disabled ids in multi-lint passes (#11122)

* fix: use empty 7702 auths (#11182)

* fix(forge): bump compilers to fix remapping sol file (#11184)

* Bump compilers 0.18.2

* Add test

* fix(coverage): disambiguate duplicate function names (#11188)

* fix(forge): set state changes journal in active fork (#11196)

* chore(ci): fix `typos` CI job failing (#11198)

fix typos

* Bump version 1.3.1 (#11199)

* fix(forge): improve error messages for etherscan verification failures (#11194)

* fix(forge): improve error messages for etherscan verification failures

* fix: cargo clippy

* tests(forge): add tests for unknown chain id

* fix: err formating for EtherscanConfigError

---------

Co-authored-by: zerosnacks <95942363+zerosnacks@users.noreply.github.com>

* chore(tests): bump forge-std version (#11174)

* chore: bump forge-std version used for tests

* Fixes

---------

Co-authored-by: DaniPopes <DaniPopes@users.noreply.github.com>
Co-authored-by: grandizzy <grandizzy.the.egg@gmail.com>

---------

Co-authored-by: Mablr <59505383+mablr@users.noreply.github.com>
Co-authored-by: zerosnacks <95942363+zerosnacks@users.noreply.github.com>
Co-authored-by: 0xrusowsky <90208954+0xrusowsky@users.noreply.github.com>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
Co-authored-by: Shiyas Mohammed <83513144+shiyasmohd@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: DaniPopes <DaniPopes@users.noreply.github.com>
MerkleBoy pushed a commit to MerkleBoy/foundry that referenced this pull request Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

anvil crash
3 participants