perf: replace format!("{}", len) with more efficient to_string() #11595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeemmmmmm
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya,
zerosnacks,
onbjerg and
0xrusowsky
as code owners
DaniPopes
added a commit
that referenced
this pull request
Sep 9, 2025
Merged
|
is this still true? |
|
sometimes, when ToString is specialized for the type. i prefer to_string regardless because i think its intent is clearer. |
MerkleBoy
pushed a commit
to MerkleBoy/foundry
that referenced
this pull request
Sep 17, 2025
This PR aggregates changes from the following PRs: - Closes foundry-rs#11572 by @\Forostovec - Closes foundry-rs#11589 by @\sashass1315 - Closes foundry-rs#11592 by @\sashaodessa - Closes foundry-rs#11595 by @\eeemmmmmm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Replace inefficient
format!("{}", value)pattern with directto_string()method call for simple numeric-to-string conversions. Theformat!macro has overhead from the formatting machinery that is unnecessary when converting a single value to string.Solution
Changed
Ok(format!("{}", code.len()))toOk(code.len().to_string())in thecodesizemethod. This micro-optimization improves performance by avoiding the format string parsing and reduces memory allocations while maintaining identical behavior.PR Checklist