refactor(cli): move EvmArgs to foundry_cli
#11741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mablr
requested review from
DaniPopes,
mattsse,
grandizzy,
yash-atreya,
zerosnacks,
onbjerg and
0xrusowsky
as code owners
mablr
commented
Sep 21, 2025
| use alloy_primitives::{Address, map::HashMap}; | ||
|
|
||
| /// Map keyed by breakpoints char to their location (contract address, pc) | ||
| pub type Breakpoints = HashMap<char, (Address, usize)>; |
There was a problem hiding this comment.
Would you like to keep Breakpoints type here or move it elsewhere ?
There was a problem hiding this comment.
I guess this is fine since it's used in more places than evmargs
DaniPopes
approved these changes
Sep 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Close #11737
Solution
Moved
EvmArgsto foundry_cli cratePR Checklist