-
Notifications
You must be signed in to change notification settings - Fork 2.3k
perf(script): run contract verifications in parallel #12753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
perf(script): run contract verifications in parallel #12753
Conversation
grandizzy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, this would be a great improvement but in order to be really useful we need verification to happen with progress showing status for each contract that is verified and not fail on first failure (see forge test --show-progress) as an example, would you be willing adding such? Thank you!
|
@grandizzy thanks for review, did changes that you requested, is it going in the right direction? |
@avorylli yep, thank you, that's going in the right direction! Some things to fix
to have |
|
ref part of #10593 CC @zerosnacks |
Added contract details tracking and inline updates for verification progress.
Refactor contract progress message formatting for clarity.
|
@grandizzy wow, thanks for detailed explanation, I hope my implementation includes what you asked for |
|
@avorylli oh, yes, I tested and def the right direction, there's still a little flakiness to figure it out, will get on review it asap |

Replace sequential await loop with join_all to execute all contract verifications concurrently.
This improves performance when verifyingmultiple contracts, especially for large deployments.
The change maintains the same error handling behavior while allowing all verification futures to run in parallel instead of waiting for each one to complete before starting the next.