Skip to content

Conversation

@aganisgash
Copy link
Contributor

Trying to figure out the gas estimated wrong issue, but no clue now.
Anyway fix this chore firstly.

@sakulstra
Copy link
Contributor

Checked the pr, but i'm not sure if it fixes/ addresses the problem.
5 retries with some fallback delay, as it currently is i think should be fine.

The problem was more that one one chain it does fallback / retry, while the other does not.

Plasma: no retry, the following error.

Response: `NOTOK`
Details: `Error: contract does not exist 9745 0x<sth>

Polygon: retry, the following error.

Submitting verification for [src/UpgradePayload.sol:UpgradePayload] 0x<sth>.
Warning: Could not detect deployment: Unable to locate ContractCode at <sth>; waiting 5 seconds before trying again (4 tries remaining)

It seems similar, but even the error is slightly different, so i guess it might be in different parts of the process.

@grandizzy
Copy link
Collaborator

Ah, I see, we should update here

if resp.result.starts_with("Unable to locate ContractCode at")

@grandizzy
Copy link
Collaborator

@aganisgash thank you for the PR, made a fix and was able to verify in #12790
Re this one, going to close for now, I think this will be greatly improved as UX with verifying contracts in parallel #12753

@grandizzy grandizzy closed this Dec 10, 2025
@github-project-automation github-project-automation bot moved this to Done in Foundry Dec 10, 2025
@aganisgash
Copy link
Contributor Author

@aganisgash thank you for the PR, made a fix and was able to verify in #12790 Re this one, going to close for now, I think this will be greatly improved as UX with verifying contracts in parallel #12753

Sure, thanks for the info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants