Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cross-platform build #244

Merged
merged 13 commits into from
Dec 19, 2021
Merged

fix: cross-platform build #244

merged 13 commits into from
Dec 19, 2021

Conversation

gakonst
Copy link
Member

@gakonst gakonst commented Dec 17, 2021 •
edited
Loading

Fixes #229:

  1. by removing the OpenSSL requirement and using Rustls as the TLS backend.
  2. by only conditionally enabling Sha2 assembly instructions (which were not available in other platforms)
  3. skips unit test for FFI on windows since that command (echo) does not exist on windows

ref:
gakonst/ethers-rs#703
alloy-rs/svm-rs#11

supersedes #218

@gakonst gakonst mentioned this pull request Dec 19, 2021
Closed
@gakonst
Copy link
Member Author

gakonst commented Dec 19, 2021 •
edited
Loading

OK so we finally got a working build. Now there's some bug in the allowed paths which we should address, and then should be good:

telegram-cloud-photo-size-2-5330311296786217226-y

@gakonst gakonst merged commit b99178c into master Dec 19, 2021
@gakonst gakonst deleted the fix/cross-platform-build branch December 19, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to compile foundry under Ubuntu 20.04
1 participant
@gakonst