fix: use lib for parsing paths correctly in windows #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
added a commit
to foundry-rs/foundry
that referenced
this pull request
Dec 19, 2021
gakonst
added a commit
to foundry-rs/foundry
that referenced
this pull request
Dec 19, 2021
gakonst
added a commit
to foundry-rs/foundry
that referenced
this pull request
Dec 19, 2021
* fix(cli): default to rustls for ssl * ci: add more workflows * windows builds w/o default features * fix: ensure build works w/o default features * chore: fmt * fix: try using platform dependent sha2/asm activation * Revert "fix: try using platform dependent sha2/asm activation" This reverts commit f589c08. The target architecture configs seem to not be respected by Cargo. * chore: default to not using sha2-asm * fix: skip FFI Test on non-Unix systems * ci: add caching * ci: remove ssl installation * chore: bump ethers to fix paths bug gakonst/ethers-rs#712 * chore: bump ethers to fix remappings non-determinism bug gakonst/ethers-rs#713
charisma98
added a commit
to charisma98/foundry
that referenced
this pull request
Mar 4, 2023
* fix(cli): default to rustls for ssl * ci: add more workflows * windows builds w/o default features * fix: ensure build works w/o default features * chore: fmt * fix: try using platform dependent sha2/asm activation * Revert "fix: try using platform dependent sha2/asm activation" This reverts commit f589c082c019ccc7ec4feee041da9ba15694cd89. The target architecture configs seem to not be respected by Cargo. * chore: default to not using sha2-asm * fix: skip FFI Test on non-Unix systems * ci: add caching * ci: remove ssl installation * chore: bump ethers to fix paths bug gakonst/ethers-rs#712 * chore: bump ethers to fix remappings non-determinism bug gakonst/ethers-rs#713
0129general
added a commit
to 0129general/FoundryProject
that referenced
this pull request
May 8, 2024
* fix(cli): default to rustls for ssl * ci: add more workflows * windows builds w/o default features * fix: ensure build works w/o default features * chore: fmt * fix: try using platform dependent sha2/asm activation * Revert "fix: try using platform dependent sha2/asm activation" This reverts commit f589c082c019ccc7ec4feee041da9ba15694cd89. The target architecture configs seem to not be respected by Cargo. * chore: default to not using sha2-asm * fix: skip FFI Test on non-Unix systems * ci: add caching * ci: remove ssl installation * chore: bump ethers to fix paths bug gakonst/ethers-rs#712 * chore: bump ethers to fix remappings non-determinism bug gakonst/ethers-rs#713
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First observed in this foundry-rs/foundry#265 PR, related to rust-lang/rust#42869. In the issue's discussion, it was recommended to use https://gitlab.com/kornelski/dunce