feat(cast): add tx command #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ports the `seth tx` command to `cast`. It follows the implementation of `cast block` and includes the feature to print a specific field in the transaction as well as printing the result in JSON. ``` $ cast tx --rpc-url <url> <tx-hash> [field] ``` The flag `-j`/`--json` is used to print the result as JSON.
mattsse
approved these changes
Dec 19, 2021
Comment on lines
+340
to
+341
| .get(field) | ||
| .cloned() |
Member
There was a problem hiding this comment.
there should be Value::take(field) which removes the value, so we could get rid of the clone here
Member
There was a problem hiding this comment.
eh in this case i guess the clone is not that expensive, one-time call expected anyway
gakonst
approved these changes
Dec 19, 2021
Member
gakonst
left a comment
gakonst
left a comment
There was a problem hiding this comment.
LGTM - lints unrelated to the pr
Comment on lines
+340
to
+341
| .get(field) | ||
| .cloned() |
Member
There was a problem hiding this comment.
eh in this case i guess the clone is not that expensive, one-time call expected anyway
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ports the
seth txcommand tocast.It follows the implementation of
cast blockand includesthe feature to print a specific field in the transaction
as well as printing the result in JSON.
The flag
-j/--jsonis used to print the resultas JSON.
A whitespace is in a docstring is removed (autoformatted on save) and
the
castREADMEis updated to indicate that thetxcommand wasimplemented. Also check off the
codecommand as it was previouslyimplemented.
Open to any stylistic feedback as I'm gaining experience writing Rust :)
The added doctest passes when I run it locally.