seth feature parity

[gakonst]

Problem & Context

Currently, cast and its cli are not at feature parity with seth.

All of Seth's commands can be found here, and the so far implemented cast commands can be found here.

Solution

Pick any of the commands that are not implemented, and go for it!

Some reference PRs on how this was done for other commands for newcomers can be seen below:

• feat: add nonce to cast #266
• feat: add cast --from-wei #261
• feat(cast): add tx command #260
• feat: add code to cast #242
• Add the max_uint subcommand to cast and cli #223

[odyslam]

@gakonst let's make this a good first issue and rename it to cast.

[raxhvl]

Can a Rust newbie take this up?

[gakonst]

Yes! These are small self-contained commands, so shouldn't require much. Take a look at the PRs linked in the OP for guidance. Also happy to review.

[raxhvl]

Update: I'm working on this. I'm an absolute beginner, please allow me some time.

[odyslam]

Update: I'm working on this. I'm an absolute beginner, please allow me some time.

I have started working on this as well. Perhaps we can coordinate and not implement the same functionality.

I have opened a draft PR while I work on it #284 and I note what I work on. Perhaps you can do as well or write a reply there?

[mds1]

I'll add comments to this issue for features that I've noticed are missing as I attempt to replace seth with cast during my normal usage:

• cast call does not support the --block <block> flag for querying historical data — done in feat: support block option in cast call #638
• as noted in the readme, cast run-tx is not supported—I used the --trace and --debug modes often - added in feat(cast): simulate published transaction locally #1358
• cast client — added in feat: cast client #635
• cast sig — added in feat: add cast sig #645
• cast index not supported — any ideas for better syntax than seth index? — added in feat(cast): Implemented cast index (seth feature parity #29) #676
• cast call <addr> <0xCalldata> is not supported. Probably just need a .starts_with('0x') block here? —done in feat(cast): implementing cast call/send <address> <0xCalldata> #742
• cast abi-encode with ints not supported, e.g. cast abi-encode "x(int256)" "-123" errors with "Found argument '-1' which wasn't expected, or isn't valid in this context" fixed in fix: support ints in cast #584
• Support for signed integers is lacking. Support I256 in format_units and parse_units gakonst/ethers-rs#842 should be completed first to make this simpler
  • unsupported in cast --to-fix because in cast/src/lib.rs the to_fix method only takes a U256. Ideal solution is to add support to ethers-rs format_units and pass through to that method
  • unsupported in cast --from-wei because in cast/src/lib.rs the from_wei method (1) takes an U256 and (2) passes through to ethers-rs format_units which does not support integers
  • unsupported in cast --to-wei because in cast/src/lib.rs the to_wei method (1) takes an U256 and (2) passes through to ethers-rs parse_units which does not support integers
  • unsupported in cast calldata because in utils/src/lib.rs the encode_args method calls parse_tokens which errors with Failed to parse tokens, though I have not looked into why

[psushi]

I'm working on cast index, after implementing exaclty what seth does, we can discus how to improve the syntax.