feat: add cast --from-wei #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
approved these changes
Dec 19, 2021
| /// Ok(()) | ||
| /// } | ||
| /// ``` | ||
| pub fn from_wei(value: U256, unit: String) -> Result<String> { |
Member
There was a problem hiding this comment.
Have you considered using the ethers_core::utils::parse_units and format_units methods? https://github.com/gakonst/ethers-rs/blob/master/ethers-core/src/utils/mod.rs#L103-L147
| /// assert_eq!(Cast::from_wei(12340000005u64.into(), "gwei".to_string())?, "12.340000005"); | ||
| /// assert_eq!(Cast::from_wei(10.into(), "ether".to_string())?, "0.00000000000000001"); | ||
| /// assert_eq!(Cast::from_wei(100.into(), "eth".to_string())?, "0.0000000000000001"); | ||
| /// assert_eq!(Cast::from_wei(17.into(), "".to_string())?, "17"); |
Member
There was a problem hiding this comment.
Yeah I agree with defaulting to this
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One thing I was not sure about here was how to handle the default behavior when a unit string is not supplied. In dapptools, it defaults to ether, however this is not consistent with the behavior of both dapptools and foundry for --to-wei, which defaults to wei when no unit string is supplied. I chose to make it default to wei, but can change it to ether if that is preferred.