Skip to content

fix(cast): change default behavior of --from-wei and --to-wei #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 1, 2022
Merged

fix(cast): change default behavior of --from-wei and --to-wei #347

merged 1 commit into from
Jan 1, 2022

Conversation

@danrobinson
Copy link
Contributor

@danrobinson danrobinson commented Jan 1, 2022

Fixes #346.

gakonst
gakonst approved these changes Jan 1, 2022
View reviewed changes
Copy link
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref #261 which introduced this

@gakonst gakonst merged commit 60e1d63 into foundry-rs:master Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gakonst gakonst gakonst approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cast --from-wei and --to-wei should assume unit is eth

2 participants

@danrobinson @gakonst