Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print details about USC compilation process when running tests #2403

Closed
cptartur opened this issue Aug 27, 2024 · 0 comments
Closed

Print details about USC compilation process when running tests #2403

cptartur opened this issue Aug 27, 2024 · 0 comments
Assignees
@ddoktorski
Labels
snforge

Comments

@cptartur
Copy link
Member

Which components does the task require to be changed? (think hard pls)

snforge

Description

Right now it doesn't give any feedback. If USC compilation is long running it might see like a forge problem.
@github-actions github-actions bot added the new label Aug 27, 2024
@cptartur cptartur removed the new label Aug 29, 2024
@ddoktorski ddoktorski mentioned this issue Sep 30, 2024
Merged
@cptartur cptartur assigned cptartur and franciszekjob and unassigned cptartur Oct 1, 2024
@cptartur cptartur assigned kkawula and unassigned franciszekjob Oct 8, 2024
@kkawula kkawula mentioned this issue Oct 15, 2024
Closed
@ddoktorski ddoktorski mentioned this issue Oct 31, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Nov 14, 2024
@ddoktorski
Keep sierra file path in TestTargetRaw (#2534)
d38bc8c 
<!-- Reference any GitHub issues resolved by this PR -->

Towards #2403

## Introduced changes

<!-- A brief description of the changes -->

- Keep sierra file path in `TestTargetRaw` so it can be printed later
github-merge-queue bot pushed a commit that referenced this issue Nov 14, 2024
@ddoktorski
Print USC compilation details (#2631)
867c645 
<!-- Reference any GitHub issues resolved by this PR -->

Closes #2403 

## Introduced changes

<!-- A brief description of the changes -->

- Print information about compiling Sierra as a spinner message
- Skip printing the path for unsaved files

## Checklist

<!-- Make sure all of these are complete -->

- [X] Linked relevant issue
- [X] Updated relevant documentation
- [X] Added relevant tests
- [X] Performed self-review of the code
- [X] Added changes to `CHANGELOG.md`
@github-project-automation github-project-automation bot moved this from In Progress to Done in Starknet foundry Nov 14, 2024
@cptartur cptartur mentioned this issue Nov 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddoktorski ddoktorski

Labels
snforge
Projects
Starknet foundry
Status: Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ddoktorski @AbdelStark @cptartur @franciszekjob @kkawula