-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print USC compilation details #2631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spinner looks cool, but when compilation takes milliseconds it appears and disappears as fast we can't read it. So maybe to inform user whats going on, we should add heading about compilation?
Sth like:
Compiling Sierra to Casm...
<spinner>
Valid point, it could be added to simply serve an information for user. Ofc it would disappear with spinner as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can think about adding a simple message that would disappear with spinner as well but this is not necessary.
Overall, I like this 👍 .
@franciszekjob if it's going to disappear then I don't think it would change much in terms of readability |
|
Nevermind, I didn't notice that the message was already added after @kkawula comment 😅 , all fine. |
Closes #2403
Introduced changes
Checklist
CHANGELOG.md