Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print USC compilation details #2631

Merged
merged 17 commits into from
Nov 14, 2024
Merged

Print USC compilation details #2631

merged 17 commits into from
Nov 14, 2024

Conversation

ddoktorski
Copy link
Contributor

@ddoktorski ddoktorski commented Oct 31, 2024

Closes #2403

Introduced changes

  • Print information about compiling Sierra as a spinner message
  • Skip printing the path for unsaved files

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

Copy link
Collaborator

@kkawula kkawula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spinner looks cool, but when compilation takes milliseconds it appears and disappears as fast we can't read it. So maybe to inform user whats going on, we should add heading about compilation?
Sth like:

Compiling Sierra to Casm...
<spinner>

@ddoktorski ddoktorski marked this pull request as ready for review November 7, 2024 15:11
@franciszekjob
Copy link
Collaborator

franciszekjob commented Nov 7, 2024

Spinner looks cool, but when compilation takes milliseconds it appears and disappears as fast we can't read it. So maybe to inform user whats going on, we should add heading about compilation? Sth like:

Compiling Sierra to Casm...
<spinner>

Valid point, it could be added to simply serve an information for user. Ofc it would disappear with spinner as well.

Copy link
Collaborator

@franciszekjob franciszekjob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can think about adding a simple message that would disappear with spinner as well but this is not necessary.

Overall, I like this 👍 .

crates/universal-sierra-compiler-api/src/utils.rs Outdated Show resolved Hide resolved
@cptartur
Copy link
Member

cptartur commented Nov 8, 2024

We can think about adding a simple message that would disappear with spinner as well but this is not necessary.

Overall, I like this 👍 .

@franciszekjob if it's going to disappear then I don't think it would change much in terms of readability

CHANGELOG.md Outdated Show resolved Hide resolved
crates/universal-sierra-compiler-api/src/lib.rs Outdated Show resolved Hide resolved
crates/universal-sierra-compiler-api/src/utils.rs Outdated Show resolved Hide resolved
@franciszekjob
Copy link
Collaborator

franciszekjob commented Nov 8, 2024

We can think about adding a simple message that would disappear with spinner as well but this is not necessary.
Overall, I like this 👍 .

@franciszekjob if it's going to disappear then I don't think it would change much in terms of readability

@cptartur I don't refer to situation when compilation is very quick. The clue of this issue is that we want to prevent the user from thinking that something is broken when compilation takes longer. Message will be helpful the way that spinner indicates Sierra to CASM compilation and not something else. not valid anymore

@franciszekjob
Copy link
Collaborator

franciszekjob commented Nov 8, 2024

We can think about adding #2631 (review) that would disappear with spinner as well but this is not necessary.

Nevermind, I didn't notice that the message was already added after @kkawula comment 😅 , all fine.

Base automatically changed from 2403-keep-sierra-program-file to master November 14, 2024 11:12
@ddoktorski ddoktorski added this pull request to the merge queue Nov 14, 2024
Merged via the queue into master with commit 867c645 Nov 14, 2024
26 checks passed
@ddoktorski ddoktorski deleted the 2403-print-usc-details branch November 14, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants