Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check deploy_at constructor issue #805

Closed
Arcticae opened this issue Oct 4, 2023 · 0 comments · Fixed by #828
Closed

Check deploy_at constructor issue #805

Arcticae opened this issue Oct 4, 2023 · 0 comments · Fixed by #828
Assignees
@Arcticae
Labels
bug Something isn't working snforge

Comments

@Arcticae
Copy link
Contributor

Arcticae commented Oct 4, 2023 •
edited
Loading

The deploy_at is not invoking the constructor (and thus storage writes), it needs to be fixed and tested.

The resolution should include deploy operations on the execution layer instead of the transactional layer. This way the implementation will be uniform and will differ by only providing/calculating the address parameter.
@Arcticae Arcticae self-assigned this Oct 4, 2023
@github-actions github-actions bot added the new label Oct 4, 2023
@Arcticae Arcticae removed the new label Oct 4, 2023
@Arcticae Arcticae moved this from Triage to TODO in Starknet foundry Oct 4, 2023
@Arcticae Arcticae moved this from TODO to In Progress in Starknet foundry Oct 4, 2023
@Arcticae Arcticae added the bug Something isn't working label Oct 4, 2023
@Arcticae Arcticae mentioned this issue Oct 5, 2023
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Oct 10, 2023
@Arcticae @piotmag769
Implement deploy in execution layer (#828)
bd93405 
<!-- Reference any GitHub issues resolved by this PR -->

Closes #805 

## Introduced changes

## Breaking changes

<!-- List of all breaking changes, if applicable -->

## Checklist

<!-- Make sure all of these are complete -->

- [ ] Linked relevant issue
- [ ] Updated relevant documentation
- [ ] Added relevant tests
- [ ] Performed self-review of the code
- [ ] Added changes to `CHANGELOG.md`

---------

Co-authored-by: Piotr Magiera <56825108+piotmag769@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Starknet foundry Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arcticae Arcticae

Labels
bug Something isn't working snforge
Projects
Starknet foundry
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement deploy in execution layer foundry-rs/starknet-foundry
1 participant
@Arcticae