Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement deploy in execution layer #828

Merged
merged 27 commits into from
Oct 10, 2023
Merged

Conversation

Arcticae
Copy link
Contributor

@Arcticae Arcticae commented Oct 5, 2023

Closes #805

Introduced changes

Breaking changes

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@Arcticae Arcticae marked this pull request as ready for review October 9, 2023 13:07
@Arcticae Arcticae requested review from a team, MaksymilianDemitraszek, Radinyn and cptartur and removed request for a team October 9, 2023 13:07
@Arcticae
Copy link
Contributor Author

Arcticae commented Oct 9, 2023

I just realized:
one test is missing (the actual one which tests that deploy_at triggers the constructor)

Working on it...

Copy link
Contributor

@MaksymilianDemitraszek MaksymilianDemitraszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please add requested test beforehand

@piotmag769 piotmag769 self-requested a review October 9, 2023 15:18
Arcticae and others added 2 commits October 10, 2023 14:18
Co-authored-by: Piotr Magiera <56825108+piotmag769@users.noreply.github.com>
@Arcticae Arcticae enabled auto-merge October 10, 2023 12:20
@Arcticae Arcticae added this pull request to the merge queue Oct 10, 2023
Merged via the queue into master with commit bd93405 Oct 10, 2023
@Arcticae Arcticae deleted the 805-deploy-in-execution-layer branch October 10, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check deploy_at constructor issue
4 participants