Support gas calculation #1037
Merged
Support gas calculation #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
war-in
requested review from
a team,
MaksymilianDemitraszek,
drknzz and
tkumor3
and removed request for
a team
war-in
requested review from
Arcticae
and removed request for
drknzz and
tkumor3
war-in
commented
Nov 3, 2023
# Conflicts: # crates/forge/src/pretty_printing.rs # crates/forge/src/running.rs # crates/forge/src/test_case_summary.rs
|
I would like to review this one before merging |
|
Please do not review 🔒 Changes are coming |
# Conflicts: # crates/forge-runner/src/running.rs # crates/forge/src/lib.rs # crates/forge/src/pretty_printing.rs
Not sure tbh, because it does not affect users (I've removed printing) |
cptartur
approved these changes
Nov 22, 2023
piotmag769
requested changes
Nov 22, 2023
piotmag769
approved these changes
Nov 22, 2023
Arcticae
reviewed
Nov 22, 2023
|
As @piotmag769 and @Arcticae mentioned, we should add support for the Created issue |
MaksymilianDemitraszek
approved these changes
Nov 27, 2023
|
Are there any test checking if gas from cheatnet is added to the final sum? |
Just added them 10974de |
# Conflicts: # crates/cheatnet/tests/starknet/resources.rs
piotmag769
reviewed
Nov 27, 2023
piotmag769
reviewed
Nov 27, 2023
Arcticae
approved these changes
Nov 28, 2023
# Conflicts: # crates/forge-runner/src/lib.rs # crates/forge-runner/src/running.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #834
Introduced changes
Checklist
CHANGELOG.md