-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support calculating gas cost of whole test execution #834
Comments
Closed
This is blocked by blockifier getting bumped to 2.3.0-rc0 or higher. |
Please do create a follow-up to parse the result and display it (for |
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 28, 2023
<!-- Reference any GitHub issues resolved by this PR --> Closes #834 ## Introduced changes <!-- A brief description of the changes --> - SierraCasmRunner was copied (and slightly modified) to enable gas calculation ## Checklist <!-- Make sure all of these are complete --> - [x] Linked relevant issue - [ ] Updated relevant documentation - [x] Added relevant tests - [x] Performed self-review of the code - [ ] Added changes to `CHANGELOG.md` --------- Co-authored-by: Kamil Jankowski <kamil.jankowski.x@gmail.com> Co-authored-by: Arcticae <tomekgsd@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When running tests, we should be able to calculate its combined gas cost, that is: cost of all code in the test itself, probably extracted from the VM using starkware-libs/cairo#4084 + the cost of blockifier calls which we are already calculating.
We should create some interface that makes the combined cost of the test available in the
run_from_test_case
starknet-foundry/crates/forge/src/running.rs
Line 72 in 894fedb
Additionally:
The text was updated successfully, but these errors were encountered: