Run tests from casm #1626
Merged
Run tests from casm #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drknzz
requested review from
Arcticae and
war-in
and removed request for
a team
Arcticae
approved these changes
Jan 30, 2024
This was referenced Jan 31, 2024
war-in
approved these changes
Feb 2, 2024
<!-- Reference any GitHub issues resolved by this PR --> Closes #1614 ## Introduced changes <!-- A brief description of the changes --> - Fixes inconsistency which is generated because of inconsistent syscall pointer when syscall_arena builtin is allocated in the segments (done only if it is required, on CASM generation level) ## Checklist <!-- Make sure all of these are complete --> - [x] Linked relevant issue - [x] Updated relevant documentation - [x] Added relevant tests - [x] Performed self-review of the code - [x] Added changes to `CHANGELOG.md`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1140
Introduced changes
SierraCasmRunnerChecklist
CHANGELOG.md