Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to CASM artifacts and new SierraCasmRunner (2.5.0) #1140

Closed
cptartur opened this issue Nov 16, 2023 · 1 comment · Fixed by #1626
Closed

Migrate to CASM artifacts and new SierraCasmRunner (2.5.0) #1140

cptartur opened this issue Nov 16, 2023 · 1 comment · Fixed by #1626
Assignees
@cptartur @drknzz
Labels
cairo-compiler snforge

Comments

@cptartur
Copy link
Member

cptartur commented Nov 16, 2023 •
edited
Loading

Create a prototype of changes required to run test from casm code either by making necessary changes to SierraCasmRunner (which would eventually be upstreamed), or changing the code to use casm_run module directly.
@cptartur cptartur converted this from a draft issue Nov 16, 2023
@github-actions github-actions bot added the new label Nov 16, 2023
@cptartur cptartur changed the title Transition to using casm artifacts for tests instead of sierra Prototype using casm artifacts for tests instead of sierra Nov 16, 2023
@cptartur cptartur added asap and removed new labels Nov 21, 2023
@cptartur cptartur moved this from Triage to TODO in Starknet foundry Nov 21, 2023
@cptartur cptartur self-assigned this Nov 21, 2023
@cptartur cptartur moved this from TODO to In Progress in Starknet foundry Nov 21, 2023
@cptartur cptartur moved this from In Progress to TODO in Starknet foundry Nov 21, 2023
@cptartur
Copy link
Member Author

Blocked until #1037 is merged, so we don't break gas calculation there.

@cptartur cptartur moved this from TODO to In Progress in Starknet foundry Nov 22, 2023
This was referenced Nov 27, 2023
Merged
Closed
Closed
@Arcticae Arcticae removed the blocked label Dec 8, 2023
@Arcticae Arcticae mentioned this issue Dec 8, 2023
Closed
@Arcticae Arcticae changed the title Prototype using casm artifacts for tests instead of sierra Migrate to CASM artifacts and new SierraCasmRunner (2.5.0) Jan 22, 2024
@Arcticae Arcticae mentioned this issue Jan 22, 2024
Closed
@drknzz drknzz mentioned this issue Jan 30, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Feb 5, 2024
@drknzz @Arcticae
Run tests from casm (#1626)
328c54a 
<!-- Reference any GitHub issues resolved by this PR -->

Closes #1140

## Introduced changes
- use upstreamed changes to `SierraCasmRunner`

## Checklist

<!-- Make sure all of these are complete -->

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests
- [x] Performed self-review of the code
- [x] Added changes to `CHANGELOG.md`

---------

Co-authored-by: Tomasz Rejowski <34059895+Arcticae@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Starknet foundry Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cptartur cptartur

@drknzz drknzz

Labels
cairo-compiler snforge
Projects
Starknet foundry
Archived in project
Milestone
No milestone
3 participants
@Arcticae @cptartur @drknzz