Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix syscall ptr bug #680

Merged
merged 20 commits into from
Oct 10, 2023
Merged

Fix syscall ptr bug #680

merged 20 commits into from
Oct 10, 2023

Conversation

MaksymilianDemitraszek
Copy link
Member

@MaksymilianDemitraszek MaksymilianDemitraszek commented Sep 18, 2023 •
edited
Loading

Closes #659

Introduced changes

  • Increments syscall_ptr of the test execution syscall handler when writing to syscall
  • Removed unnecessary implementation
  • Slightly refactored buffer reading (we do it only in one place so I restrained from abstracting it too much)

Breaking changes

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@MaksymilianDemitraszek MaksymilianDemitraszek mentioned this pull request Sep 18, 2023
Closed
@cptartur
Copy link
Member

cptartur commented Oct 3, 2023

Is the work on this going to be continued in the future or should this PR be closed?

@MaksymilianDemitraszek
Copy link
Member Author

cc @abulenok if you are interested

@MaksymilianDemitraszek MaksymilianDemitraszek marked this pull request as ready for review October 5, 2023 10:06
@MaksymilianDemitraszek MaksymilianDemitraszek requested review from a team, Arcticae, Radinyn, tkumor3 and cptartur and removed request for a team October 5, 2023 10:06
Arcticae
Arcticae requested changes Oct 5, 2023
View reviewed changes
crates/forge/src/test_execution_syscall_handler.rs Show resolved Hide resolved
crates/forge/src/test_execution_syscall_handler.rs Show resolved Hide resolved
crates/forge/src/test_execution_syscall_handler.rs Outdated Show resolved Hide resolved
crates/cheatnet/src/execution/syscalls.rs Outdated Show resolved Hide resolved
crates/cheatnet/src/execution/syscalls.rs Outdated Show resolved Hide resolved
@piotmag769 piotmag769 self-requested a review October 9, 2023 10:44
@MaksymilianDemitraszek MaksymilianDemitraszek added this pull request to the merge queue Oct 10, 2023
Merged via the queue into master with commit 9fae8c7 Oct 10, 2023
@MaksymilianDemitraszek MaksymilianDemitraszek deleted the 659-pointer-bug-fix branch October 10, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abulenok abulenok abulenok left review comments

@piotmag769 piotmag769 piotmag769 approved these changes

@Arcticae Arcticae Arcticae approved these changes

@Radinyn Radinyn Awaiting requested review from Radinyn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calling a contract and then using get_block_number fails
5 participants
@MaksymilianDemitraszek @cptartur @Arcticae @piotmag769 @abulenok