Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling a contract and then using get_block_number fails #659

Closed
piotmag769 opened this issue Sep 13, 2023 · 3 comments · Fixed by #680
Closed

Calling a contract and then using get_block_number fails #659

piotmag769 opened this issue Sep 13, 2023 · 3 comments · Fixed by #680
Assignees
@MaksymilianDemitraszek @abulenok
Labels
bug Something isn't working snforge
Milestone
Starknet unit tes...

Comments

@piotmag769
Copy link
Member 

          still fails if trying to use `get_block_number` and mock calls at same time:
Screenshot 2023-09-13 at 18 58 24

Originally posted by @delaaxe in #645 (comment)
@piotmag769 piotmag769 added bug Something isn't working Component: Forge labels Sep 13, 2023
@github-actions github-actions bot added the new label Sep 13, 2023
@cptartur cptartur removed the new label Sep 14, 2023
@cptartur cptartur moved this from Triage to In Progress in Starknet foundry Sep 14, 2023
Merged
5 tasks
@MaksymilianDemitraszek MaksymilianDemitraszek removed their assignment Sep 18, 2023
@MaksymilianDemitraszek
Copy link
Member

@cptartur PR with failing test #680

@Arcticae Arcticae removed the snforge label Sep 19, 2023
@MaksymilianDemitraszek
Copy link
Member

@abulenok you probably should look if #612 will fix this one as well

@delaaxe delaaxe mentioned this issue Sep 24, 2023
Merged
@lambda-0x lambda-0x mentioned this issue Sep 28, 2023
Merged
2 tasks
@delaaxe
Copy link

delaaxe commented Sep 29, 2023 •
edited
Loading

PR tracking this problem: keep-starknet-strange/satoru#383 (still the case on 0.7.0)

@MaksymilianDemitraszek MaksymilianDemitraszek self-assigned this Oct 5, 2023
github-merge-queue bot pushed a commit that referenced this issue Oct 10, 2023
@MaksymilianDemitraszek
Fix syscall ptr bug (#680)
9fae8c7 
<!-- Reference any GitHub issues resolved by this PR -->

Closes #659

## Introduced changes

<!-- A brief description of the changes -->

- Increments syscall_ptr of the test execution syscall handler when
writing to syscall
- Removed unnecessary implementation
- Slightly refactored buffer reading (we do it only in one place so I
restrained from abstracting it too much)


## Breaking changes

<!-- List of all breaking changes, if applicable -->

## Checklist

<!-- Make sure all of these are complete -->

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests
- [x] Performed self-review of the code
- [x] Added changes to `CHANGELOG.md`
@github-project-automation github-project-automation bot moved this from In Progress to Done in Starknet foundry Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaksymilianDemitraszek MaksymilianDemitraszek

@abulenok abulenok

Labels
bug Something isn't working snforge
Projects
Starknet foundry
Archived in project
Milestone
Starknet unit testing
Development

Successfully merging a pull request may close this issue.

Fix syscall ptr bug foundry-rs/starknet-foundry
6 participants
@delaaxe @MaksymilianDemitraszek @Arcticae @cptartur @piotmag769 @abulenok