Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add a test for exchange_utils #383

Merged
merged 17 commits into from
Oct 19, 2023

Conversation

delaaxe
Copy link
Contributor

@delaaxe delaaxe commented Sep 13, 2023

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

  • Testing

What is the current behavior?

Resolves: #281

Other information

blocked by this foundry issue: foundry-rs/starknet-foundry#659

@delaaxe delaaxe requested a review from AbdelStark as a code owner September 13, 2023 12:19
@delaaxe delaaxe marked this pull request as draft September 13, 2023 12:19
@delaaxe
Copy link
Contributor Author

delaaxe commented Sep 24, 2023

blocked by this foundry issue: foundry-rs/starknet-foundry#659

@delaaxe delaaxe marked this pull request as ready for review October 18, 2023 22:28
@delaaxe
Copy link
Contributor Author

delaaxe commented Oct 18, 2023

@zarboq @sparqet you can review

Copy link
Collaborator

@zarboq zarboq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test naming issue, else everything looks good 🔥

tests/exchange/test_exchange_utils.cairo Outdated Show resolved Hide resolved
@zarboq zarboq merged commit 6ce3682 into keep-starknet-strange:main Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: add a test for exchange_utils
3 participants