Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Btrfs implementation #1

Merged
merged 23 commits into from
Nov 8, 2023
Merged

Add Btrfs implementation #1

merged 23 commits into from
Nov 8, 2023

Conversation

Schamper
Copy link
Member

(DIS-375)

@Schamper Schamper self-assigned this Jul 14, 2023
cecinestpasunepipe
cecinestpasunepipe suggested changes Aug 11, 2023
View reviewed changes
Copy link

@cecinestpasunepipe cecinestpasunepipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prelim. review. Tested on Fedora 38 BTRFs partition. Seems to work fine. To test this I created a draft btrfs impl. for dissect.target. Some minor suggestions.

cecinestpasunepipe
cecinestpasunepipe previously approved these changes Aug 17, 2023
View reviewed changes
Copy link

@cecinestpasunepipe cecinestpasunepipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me, we probably find out how well it works if we start using it.

@Schamper Schamper mentioned this pull request Aug 22, 2023
Merged
Miauwkeru
Miauwkeru reviewed Aug 25, 2023
View reviewed changes
@pyrco pyrco removed their request for review August 29, 2023 07:22
@Schamper Schamper requested a review from Miauwkeru September 5, 2023 22:17
@Schamper
Copy link
Member Author

@Miauwkeru I've fixed that other issue you encountered with 3fa8159. For good measure I've added this to must .iter() calls, but I'm not sure if that's necessary. May need to be compared with the original source but I didn't have the time to do that yet.

Miauwkeru
Miauwkeru requested changes Sep 21, 2023
View reviewed changes
@Schamper Schamper requested a review from Miauwkeru September 25, 2023 23:34
Schamper and others added 2 commits October 3, 2023 21:34
@Schamper
Use a crc32c library with a happier license
2b3f00e
@Schamper @Miauwkeru
Update dissect/btrfs/stream.py
748d140 
Co-authored-by: Miauwkeru <Miauwkeru@users.noreply.github.com>
Miauwkeru
Miauwkeru requested changes Oct 11, 2023
View reviewed changes
@Schamper Schamper requested a review from Miauwkeru October 11, 2023 14:24
Miauwkeru
Miauwkeru previously approved these changes Nov 7, 2023
View reviewed changes
@Schamper Schamper merged commit fe7cddf into main Nov 8, 2023
@Schamper Schamper deleted the implement-btrfs branch November 8, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miauwkeru Miauwkeru Miauwkeru approved these changes

@cecinestpasunepipe cecinestpasunepipe cecinestpasunepipe left review comments

Assignees

@Schamper Schamper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Schamper @Miauwkeru @cecinestpasunepipe