Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dissect.btrfs #370

Merged
merged 6 commits into from
Nov 20, 2023
Merged

Add support for dissect.btrfs #370

merged 6 commits into from
Nov 20, 2023

Conversation

Schamper
Copy link
Member

Depends on fox-it/dissect.btrfs#1.

I'm looking for feedback on how I currently implemented multi-volume filesystems + sub-filesystem support. I'm not 100% sure if it isn't too hairy.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Attention: 168 lines in your changes are missing coverage. Please review.

Comparison is base (a4003f5) 74.38% compared to head (190caa6) 73.90%.

Files Patch % Lines
dissect/target/filesystems/btrfs.py 2.60% 112 Missing ⚠️
dissect/target/filesystem.py 53.06% 23 Missing ⚠️
dissect/target/plugins/os/unix/_os.py 16.66% 20 Missing ⚠️
dissect/target/helpers/utils.py 36.36% 7 Missing ⚠️
dissect/target/target.py 78.57% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #370      +/-   ##
==========================================
- Coverage   74.38%   73.90%   -0.49%     
==========================================
  Files         258      259       +1     
  Lines       20661    20838     +177     
==========================================
+ Hits        15369    15400      +31     
- Misses       5292     5438     +146     
Flag Coverage Δ
unittests 73.90% <26.63%> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pyrco pyrco removed their request for review August 29, 2023 07:22
Copy link
Contributor

@Miauwkeru Miauwkeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An initial read through the code, will check more in depth later

Miauwkeru
Miauwkeru previously approved these changes Nov 7, 2023
@Miauwkeru
Copy link
Contributor

Now that btrfs is opensource, i'd add it to the [full] in the pyproject.toml

@Schamper Schamper merged commit 3000dcf into main Nov 20, 2023
@Schamper Schamper deleted the btrfs-support branch November 20, 2023 14:57
JSCU-CNI pushed a commit to JSCU-CNI/dissect.target that referenced this pull request Jan 2, 2024
Poeloe pushed a commit that referenced this pull request Feb 29, 2024
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants