Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mimikatz binary in quarantine data with DUMMY_PAYLOAD #524

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

Miauwkeru
Copy link
Contributor

@Miauwkeru Miauwkeru commented Feb 2, 2024

So windows defender doesn't remove it

(DIS-2787)

@Miauwkeru Miauwkeru requested a review from Poeloe February 2, 2024 13:46
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4a5f27f) 73.68% compared to head (f79de28) 73.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #524   +/-   ##
=======================================
  Coverage   73.68%   73.68%           
=======================================
  Files         277      277           
  Lines       23052    23052           
=======================================
  Hits        16987    16987           
  Misses       6065     6065           
Flag Coverage Δ
unittests 73.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

So windows defender doesn't replace it

(DIS-2787)
@Miauwkeru Miauwkeru force-pushed the dis-2787_fix-defender-tests branch from 47907cb to f79de28 Compare February 2, 2024 14:22
Copy link
Contributor

@Poeloe Poeloe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Miauwkeru Miauwkeru merged commit da9cd96 into main Feb 6, 2024
16 checks passed
@Miauwkeru Miauwkeru deleted the dis-2787_fix-defender-tests branch February 6, 2024 12:08
Poeloe pushed a commit that referenced this pull request Feb 29, 2024
So windows defender doesn't remove it

(DIS-2787)
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants