Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mimikatz binary in quarantine data with DUMMY_PAYLOAD #524

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Replace mimikatz binary in quarantine data with DUMMY_PAYLOAD #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...s/os/windows/defender/quarantine/ResourceData/A6/A6C8322B8A19AEED96EFBD045206966DA4C9619D
View file
Open in desktop
Binary file not shown.
14 changes: 2 additions & 12 deletions tests/plugins/os/windows/test_defender.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
import os
import platform
from datetime import datetime
from io import BytesIO
from pathlib import Path

import pytest
from dissect.ntfs.secure import ACL, SecurityDescriptor

from dissect.target.filesystem import VirtualFilesystem
Expand Down Expand Up @@ -60,11 +58,6 @@ def test_defender_quarantine_entries(target_win: Target, fs_win: VirtualFilesyst
assert mimikatz_record.last_accessed_time.date() == detection_date


@pytest.mark.skipif(
platform.system() == "Windows",
reason="Windows Defender cleans up the restored quarentine files when you try to open it.",
)
# TODO: Create a more sane quarentine file for this.
def test_defender_quarantine_recovery(target_win: Target, fs_win: VirtualFilesystem, tmp_path: Path) -> None:
# Map the quarantine folder from our test data
quarantine_dir = absolute_path("_data/plugins/os/windows/defender/quarantine")
Expand Down Expand Up @@ -94,11 +87,8 @@ def test_defender_quarantine_recovery(target_win: Target, fs_win: VirtualFilesys
directory_content = os.listdir(recovery_dst)
directory_content.sort()
assert expected_files == directory_content

# Verify that the payloads are both properly restored by checking for the MZ header
with open(recovery_dst.joinpath(payload_filename), "rb") as payload_file:
header = payload_file.read(2)
assert header == b"MZ"
# Replaced the mimikatz payload with `DUMMY_PAYLOAD` to avoid defender collecting it
assert recovery_dst.joinpath(payload_filename).read_bytes() == b"DUMMY_PAYLOAD"

# Verify that the security descriptors are valid security descriptors
with open(recovery_dst.joinpath(security_descriptor_filename), "rb") as descriptor_file:
Expand Down
Loading