Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor catroot plugin #559

Merged
merged 11 commits into from
Mar 8, 2024
Merged

Refactor catroot plugin #559

merged 11 commits into from
Mar 8, 2024

Conversation

Poeloe
Copy link
Contributor

@Poeloe Poeloe commented Feb 29, 2024

(DIS-2199)

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 91.13924% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 74.51%. Comparing base (4be9d94) to head (c30a47a).
Report is 1 commits behind head on main.

Files Patch % Lines
dissect/target/plugins/os/windows/catroot.py 91.13% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #559      +/-   ##
==========================================
+ Coverage   74.31%   74.51%   +0.20%     
==========================================
  Files         286      286              
  Lines       23617    23653      +36     
==========================================
+ Hits        17551    17626      +75     
+ Misses       6066     6027      -39     
Flag Coverage Δ
unittests 74.51% <91.13%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Poeloe Poeloe force-pushed the feature/refactor-catroot-plugin-2 branch from 74fa400 to 4e90d7d Compare February 29, 2024 17:11
@Poeloe Poeloe force-pushed the feature/refactor-catroot-plugin-2 branch from a607448 to acd5c60 Compare March 1, 2024 14:37
@Poeloe Poeloe force-pushed the feature/refactor-catroot-plugin-2 branch 2 times, most recently from 7d3a686 to 76f6e64 Compare March 1, 2024 15:45
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
@Poeloe Poeloe force-pushed the feature/refactor-catroot-plugin-2 branch 2 times, most recently from 8c7539d to 3764b41 Compare March 8, 2024 13:40
@Poeloe Poeloe force-pushed the feature/refactor-catroot-plugin-2 branch from 3764b41 to b3019ee Compare March 8, 2024 13:42
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
@Poeloe Poeloe merged commit 51e1d1a into main Mar 8, 2024
18 checks passed
@Poeloe Poeloe deleted the feature/refactor-catroot-plugin-2 branch March 8, 2024 15:32
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants