Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor catroot plugin #559

Merged
merged 11 commits into from
Mar 8, 2024

Apply suggestions from code review

c30a47a
Select commit
Loading
Failed to load commit list.
Merged

Refactor catroot plugin #559

Apply suggestions from code review
c30a47a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Mar 8, 2024 in 0s

91.13% of diff hit (target 74.31%)

View this Pull Request on Codecov

91.13% of diff hit (target 74.31%)

Annotations

Check warning on line 81 in dissect/target/plugins/os/windows/catroot.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dissect/target/plugins/os/windows/catroot.py#L81 

Added line #L81 was not covered by tests

Check warning on line 135 in dissect/target/plugins/os/windows/catroot.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dissect/target/plugins/os/windows/catroot.py#L135 

Added line #L135 was not covered by tests

Check warning on line 137 in dissect/target/plugins/os/windows/catroot.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dissect/target/plugins/os/windows/catroot.py#L137 

Added line #L137 was not covered by tests

Check warning on line 173 in dissect/target/plugins/os/windows/catroot.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dissect/target/plugins/os/windows/catroot.py#L172-L173 

Added lines #L172 - L173 were not covered by tests

Check warning on line 188 in dissect/target/plugins/os/windows/catroot.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dissect/target/plugins/os/windows/catroot.py#L187-L188 

Added lines #L187 - L188 were not covered by tests
View more details on Codecov