Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lru_cache for UsersPlugin's find method #567

Merged
merged 5 commits into from
Mar 7, 2024
Merged

Add lru_cache for UsersPlugin's find method #567

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5ea4658
Add lru_cache for UsersPlugin's find method
Poeloe Mar 6, 2024
a3764b4
Process review feedback
Poeloe Mar 6, 2024
024e9d5
Process review feedback
Poeloe Mar 7, 2024
90a5aab
Merge branch 'main' into feature/add-lru-cache-for-find-in-UsersPlugin
Poeloe Mar 7, 2024
0954d19
Merge branch 'main' into feature/add-lru-cache-for-find-in-UsersPlugin
Poeloe Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions dissect/target/plugins/general/users.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
from functools import lru_cache
from typing import Generator, NamedTuple, Optional, Union

from dissect.target import Target
from dissect.target.exceptions import UnsupportedPluginError
from dissect.target.helpers.fsutil import TargetPath
from dissect.target.helpers.record import UnixUserRecord, WindowsUserRecord
Expand All @@ -16,6 +18,10 @@ class UsersPlugin(InternalPlugin):

__namespace__ = "user_details"

def __init__(self, target: Target):
super().__init__(target)
self.find = lru_cache(32)(self.find)

def check_compatible(self) -> None:
if not hasattr(self.target, "users"):
raise UnsupportedPluginError("Unsupported Plugin")
Expand Down
Loading