Create separate LayerFilesystem from RootFilesystem #575
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #575 +/- ##
==========================================
+ Coverage 74.84% 74.90% +0.06%
==========================================
Files 288 288
Lines 24048 24103 +55
==========================================
+ Hits 17998 18055 +57
+ Misses 6050 6048 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tests/test_filesystem.py
Outdated
| assert lfs.path("file1").read_text() == "value1" | ||
| lfs.remove_fs_layer(vfs4) | ||
| lfs.prepend_fs_layer(vfs4) | ||
| assert lfs.path("file1").read_text() == "value4" |
There was a problem hiding this comment.
Would you not want the most recently added layer to be dominant over any previously added layer?
There was a problem hiding this comment.
Maybe. I've currently kept it this way because that's how it behaved before. I'll throw it up for opinion within the team.
There was a problem hiding this comment.
After a short but powerful vote we've indeed decided that it's best to reverse this now. We'll need to perform some testing to make sure everything works as expected for ESXi and FortiOS (two heavy users of the layers). Do you still have some FortiOS test images that you could perhaps test these changes against?
There was a problem hiding this comment.
Seems to be working OK on FortiGate VMs. The syntax stays the same, right? FortiOS plugin currently uses:
target.fs.add_layer().mount("/foo", TarFilesystem(...))
There was a problem hiding this comment.
Yeah, syntax is the same, just the resolution order is changed. I didn't expect anything to break, but always good to verify!
Schamper
force-pushed
the
separate-root-layer-fs
branch
from
419bd05 to
3ebb99b
Compare
No description provided.