Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple accessors in Velociraptor loader #576

Merged
merged 9 commits into from
Apr 18, 2024

Conversation

Schamper
Copy link
Member

Depends on #575, so targeted to that for now.

Fixes #573

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.11%. Comparing base (0993094) to head (54c530a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #576      +/-   ##
==========================================
+ Coverage   75.09%   75.11%   +0.01%     
==========================================
  Files         291      291              
  Lines       24700    24716      +16     
==========================================
+ Hits        18549    18565      +16     
  Misses       6151     6151              
Flag Coverage Δ
unittests 75.11% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper force-pushed the separate-root-layer-fs branch from 419bd05 to 3ebb99b Compare March 15, 2024 11:37
Base automatically changed from separate-root-layer-fs to main April 3, 2024 14:01
Copy link
Contributor

@Miauwkeru Miauwkeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know how to fix velociraptor with multiple accessors, but was able to still use this with velociraptor.

I do see the doc string of the loader should now be updated, no?

@Schamper Schamper requested a review from Miauwkeru April 17, 2024 16:48
@Schamper Schamper merged commit c22059e into main Apr 18, 2024
16 checks passed
@Schamper Schamper deleted the fix-velo-multiple-accessor branch April 18, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsupported plugin error for several plugins in dissect version 3.13
3 participants