Fix exception parameter not being used (#194)

### Public-Facing Changes
None

### Description
- Enables stricter clang compilation flags
- Fix unused exception parameter

fixes #193

CMakeLists.txt

@@ -15,10 +15,13 @@ set(CMAKE_CXX_STANDARD 17)
 set(CMAKE_CXX_STANDARD_REQUIRED ON)
 
 macro(enable_strict_compiler_warnings target)
-  target_compile_options(${target} PRIVATE
-    $<$<CXX_COMPILER_ID:MSVC>:/WX /W4>
-    $<$<NOT:$<CXX_COMPILER_ID:MSVC>>:-Wall -Wextra -Wpedantic -Werror -Wold-style-cast -Wfloat-equal>
-  )
+  if (MSVC)
+    target_compile_options(${target} PRIVATE /WX /W4)
+  elseif(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
+    target_compile_options(${target} PRIVATE -Wall -Wextra -Wpedantic -Werror -Wold-style-cast -Wfloat-equal -Wmost -Wunused-exception-parameter)
+  else()
+    target_compile_options(${target} PRIVATE -Wall -Wextra -Wpedantic -Werror -Wold-style-cast -Wfloat-equal)
+  endif()
 endmacro()
 
 find_package(nlohmann_json QUIET)

ros1_foxglove_bridge/src/ros1_foxglove_bridge_nodelet.cpp

@@ -453,8 +453,8 @@ class FoxgloveBridge : public nodelet::Nodelet {
     try {
       channelPublicationIt->second.publish(msg);
     } catch (const std::exception& ex) {
-      ROS_ERROR("Failed to publish message on topic '%s'",
-                channelPublicationIt->second.getTopic().c_str());
+      ROS_ERROR("Failed to publish message on topic '%s': %s",
+                channelPublicationIt->second.getTopic().c_str(), ex.what());
     }
   }