Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused exception variable warning not detected by CI #193

Closed
achim-k opened this issue Mar 10, 2023 · 1 comment · Fixed by #194
Closed

Unused exception variable warning not detected by CI #193

achim-k opened this issue Mar 10, 2023 · 1 comment · Fixed by #194
Labels
linear

Comments

@achim-k
Copy link
Collaborator

achim-k commented Mar 10, 2023 

          The exception parameter `ex` is not used and should have caused CI to fail!

Originally posted by @achim-k in #191 (comment)
@achim-k achim-k added the linear label Mar 10, 2023
@achim-k achim-k changed the title Unused parameter warning not detected by CI Unused exception variable warning not detected by CI Mar 10, 2023
@achim-k
Copy link
Collaborator Author

achim-k commented Mar 10, 2023

From https://stackoverflow.com/a/56085300:

Clang
Bug report: https://bugs.llvm.org/show_bug.cgi?id=41746

It turns out that clang has the warning -Wunused-exception-parameter, although it is not activated by any of the groups -Wall, -Wextra, or -Wunused.

GCC
Bug report: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90353

As noted in a comment to this question and in the bug report, all catch parameters are always marked as used. This is being investigated in the linked bug report.

@achim-k achim-k mentioned this issue Mar 10, 2023
Merged
achim-k added a commit that referenced this issue Mar 10, 2023
@achim-k
Fix exception parameter not being used (#194)
c99ef97 
### Public-Facing Changes
None

### Description
- Enables stricter clang compilation flags
- Fix unused exception parameter

fixes #193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
linear
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix exception parameter not being used foxglove/ros-foxglove-bridge
1 participant
@achim-k